aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNunoSempere <nuno.sempere@protonmail.com>2023-03-28 12:00:07 -0600
committerNunoSempere <nuno.sempere@protonmail.com>2023-03-28 12:01:08 -0600
commitdbc334e870234e661648492b7eb9b5d2fe3f307e (patch)
tree0c7aacf81306777dd19ec46d5af4f0b0bf963c48
parentb2bc83ce80af5c47a0c8855470323189c5f1f718 (diff)
chore: more cleanup
-rw-r--r--README.md8
-rw-r--r--rose.c7
2 files changed, 8 insertions, 7 deletions
diff --git a/README.md b/README.md
index 8a83099..3c47e82 100644
--- a/README.md
+++ b/README.md
@@ -49,12 +49,12 @@ You can also see more detailed instructions [here](./user-scripts/ubuntu-20.04/i
- [ ] Double check newtab/next-tab behavior
- [ ] Find out what each of the css elements refers to.
- [ ] Use something other than Whatsapp as an example syslink.
-- [ ] Set `webkit_web_context_set_sandbox_enabled` (<https://webkitgtk.org/reference/webkit2gtk/2.36.8/WebKitWebContext.html#webkit-web-context-set-sandbox-enabled>), as recommended here: <https://blogs.gnome.org/mcatanzaro/2022/11/04/stop-using-qtwebkit/>.
-- [ ] Fix bug about distorted audio. Maybe related to <https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1547>
+- [ ] Set [`webkit_web_context_set_sandbox_enabled`](<https://webkitgtk.org/reference/webkit2gtk/2.36.8/WebKitWebContext.html#webkit-web-context-set-sandbox-enabled>), as recommended [here](<https://blogs.gnome.org/mcatanzaro/2022/11/04/stop-using-qtwebkit/>)
+- [ ] Fix bug about distorted audio. Maybe related to [this pipewire issue](<https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1547>)?
Done:
-- [x] Document stand_in.c better
+- [x] Document `stand_in.c` better
- [x] Use a makefile.
- [x] Add clean, uninstall to makefile
- [x] Mask user agent
@@ -69,7 +69,7 @@ Done:
- [x] Add "open in new window" functionality.
- Useful for opening links in new tab when clicking on them and selecting that option
- And for actually opening links with the href new_tab option.
- - Links: <https://docs.gtk.org/gobject/func.signal_connect.html>, <https://webkitgtk.org/reference/webkit2gtk/2.37.90/signal.AutomationSession.create-web-view.html>, <https://webkitgtk.org/reference/webkit2gtk/2.26.0/WebKitWebView.html#WebKitWebView-create> <https://stackoverflow.com/questions/40180757/webkit2gtk-get-new-window-link>
+ - Links: [1](<https://docs.gtk.org/gobject/func.signal_connect.html>), [2](<https://webkitgtk.org/reference/webkit2gtk/2.37.90/signal.AutomationSession.create-web-view.html>), [3](<https://webkitgtk.org/reference/webkit2gtk/2.26.0/WebKitWebView.html#WebKitWebView-create>), [4](<https://stackoverflow.com/questions/40180757/webkit2gtk-get-new-window-link>)
### Known bugs
diff --git a/rose.c b/rose.c
index 454fc55..75f90f7 100644
--- a/rose.c
+++ b/rose.c
@@ -22,9 +22,10 @@ int CUSTOM_USER_AGENT = true;
// - set their variable to true
// - in build.sh, uncomment: REQS= #./plugins/*/*.c
// 2. Remove stand_in code;
-// - Comment out #include "plugins/stand_in/stand_in.h" line, or edit it
-// together with stand_in.c so as to not include the plugin functions.
-// - In build.sh, comment out REQS=./plugins/stand_in/stand_in.c
+// - Add an #include "plugins/stand_in/stand_in.h" line, and modify
+// stand_in.c so as to include stand-in functions for the excluded plugin
+// - In the make file, include the stand_in.c file and exclude the
+// relevant plugin
#define CACHE \
"base-cache-directory", CACHE_DIR, "base-data-directory", CACHE_DIR, \